Conversation
7347ccd to
0f86900
Compare
nathanjcochran
left a comment
There was a problem hiding this comment.
LGTM!
I haven't looked at other places it could be used yet, but there's no doubt a bunch.
Yeah, I think this could also be applied to the tiger db commands. I believe all/most of them also take a service ID as an argument. Would be nice to wire them up in this PR, but we can do it in a follow-up if you'd rather.
We should think about how the completion should be displayed as well (ie., show
serviceID(name)? Mix serviceIDs and names in the same list?
If we could display the service name along with the service ID, but just complete the service ID, I think that would be awesome. Based on the docs, I think that should be possible via CompletionWithDesc? Anyways, that can definitely be a follow-up.
0f86900 to
a6dcd9c
Compare
Done.
Nice- I never noticed the CompletionWithDesc, thanks for pointing it out! |
It's a quick add for serviceID's in service commands. I haven't looked at other places it could be used yet, but there's no doubt a bunch. We should think about how the completion should be displayed as well (ie., show
serviceID(name)? Mix serviceIDs and names in the same list?