Conversation
deadprogram
left a comment
deadprogram
left a comment
There was a problem hiding this comment.
Looks good @bgould just is missing machine.NINA_UART
https://github.com/tinygo-org/bluetooth/blob/dev/adapter_ninafw.go#L53
bgould
force-pushed
the
ninafw-custom-config
branch
from
b65e00d to
2838920
Compare
bgould
force-pushed
the
ninafw-custom-config
branch
from
2838920 to
731e738
Compare
bgould
force-pushed
the
ninafw-custom-config
branch
from
731e738 to
f100ba6
Compare
|
@deadprogram This is rebased against the latest from the dev branch and ready for feedback/merging |
| const maxConnections = 1 | ||
|
|
||
| // NINAConfig encapsulates the hardware options for the NINA firmware | ||
| type NINAConfig struct { |
There was a problem hiding this comment.
I suggest name this HCIConfig so it can be more easily used for non-NINA HCI controllers.
| @@ -0,0 +1,22 @@ | |||
| //go:build ninafw && ninafw_featherwing_init | |||
There was a problem hiding this comment.
I think ninafw_featherwing_init can just be featherwing.
| @@ -0,0 +1,22 @@ | |||
| //go:build ninafw && ninafw_machine_init | |||
There was a problem hiding this comment.
How about name ninafw_machine_init instead to ninafw_onboard?
|
@bgould I made a few comments. What I have in mind is to create a |
|
What's the status of this PR? This looks like a good idea to me (and I agree with the suggestions of @deadprogram). |
3 participants
Refactoring ninafw adapter to allow for settings and pin configurations separate from the
machinepackage.