monthly-check: improve username validation workflow

[waldyrious]

Refactor the monthly username validation workflow for improved clarity and maintainability.

Also update lychee.md to the link to the CLI documentation page in the docs site.

[waldyrious]

There's no need to only update an existing issue if it is open; so I changed this to search for closed ones too, and modified the last step in the workflow to reopen the closed issue if needed.

[waldyrious]

I explicitly defined the output filename here, rather than let the action use the default one, since it's referenced further down in the workflow, and this way it is a bit clearer where it comes from.

[waldyrious]

(I wanted to also rename the file from monthly-check.yml to monthly-username-check.yml, but then git/github stopped being able to recognize that it was the same file, and showed the diff as a deleted file and an added one. I might do that change in a separate PR.)

[waldyrious]

Btw, the current workflow doesn't seem to be working correctly: the last run did fail to load some of the userpages (though for reasons other than them actually being invalid), but skipped the issue update steps, for reasons that are not clear to me.

Screenshot of the job log/output for future reference, since they will eventually be deleted:

[sbrl]

Looks cool, and definitely improves maintainability here! Just thought I'd drop some comments while I'm thinking about it haha

[sebastiaanspeck]

Btw, the current workflow doesn't seem to be working correctly: the last run did fail to load some of the userpages (though for reasons other than them actually being invalid), but skipped the issue update steps, for reasons that are not clear to me.

Screenshot of the job log/output for future reference, since they will eventually be deleted:

Could you test if this PR fixed the issue?

[sebastiaanspeck]

Suggested change

	grep -oP '@[\w-]+' .github/CODEOWNERS
	grep -oP '@[\w-]+' .github/CODEOWNERS

[waldyrious]

I did it that way to make it more obvious that both patterns are looking for the same thing, with the only difference being the ** prefix in the second one. Do you think it makes it more confusing than helpful?

[sebastiaanspeck]

I actually meant to remove the extra whitespace between the command and the regex. Besides that, I am not a big fan of using grep -P since -P isn't usable on MacOS.

[waldyrious]

Could you test if this PR fixed the issue?

Sure. How can I do that test? Maybe temporarily changing the triggering conditions of the workflow so it executes in this PR?

[sebastiaanspeck]

Could you test if this PR fixed the issue?

Sure. How can I do that test? Maybe temporarily changing the triggering conditions of the workflow so it executes in this PR?

We do have workflow_dispatch already, so you can trigger it manually on this branch.

[waldyrious]

Thanks! That seems to have done the trick: https://github.com/tldr-pages/tldr/actions/runs/19003751429/job/54274077842

I think I might change the action to add a comment to the issue instead of modifying the existing opening comment, to make the historical progression easier to follow.

[sbrl]

Cool!

(take my time suggestion or leave it, it's p minor)

[sebastiaanspeck]

Thanks! That seems to have done the trick: https://github.com/tldr-pages/tldr/actions/runs/19003751429/job/54274077842

I think I might change the action to add a comment to the issue instead of modifying the existing opening comment, to make the historical progression easier to follow.

I see we still have the issue about running into a 403 for 10 valid users. Are you able to fix that as well?

[sbrl]

conflicts seem to have arisen with the main branch

also, /cc @waldyrious?

[waldyrious]

(I haven't abandoned this, but it will take me a few more days to have the time to implement the changes I mentioned above.)

[sebastiaanspeck]

(I haven't abandoned this, but it will take me a few more days to have the time to implement the changes I mentioned above.)

Shall we mark it as draft until you have time?

[waldyrious]

Thanks for changing this to a draft, @sebastiaanspeck. Indeed I ended up becoming busier than I expected in the past couple weeks. I'll get back to this as soon as I can spare the bandwidth to pick up the work.

[sebastiaanspeck]

@waldyrious any update on this?

[waldyrious]

Not yet, I'm afraid. I've got a lot going on and will likely have to attend to other topics before returning to this one.