fix: escapeTag correctly works with booleans#543
Open
DamianCSpendesk wants to merge 1 commit intotngan:masterfrom
Open
fix: escapeTag correctly works with booleans#543DamianCSpendesk wants to merge 1 commit intotngan:masterfrom
DamianCSpendesk wants to merge 1 commit intotngan:masterfrom
Conversation
Author
|
@tngan Sorry for the ping - for whatever reason, I can't add you as a reviewer |
|
@tngan can this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In relation to #538, the issue boils down to the code in
escapeTag, where we callThis fails for "falsey" values, in our case for
AllowCreatebeingfalse. Even passingtrue, we end up with an error as thexml-escapelib used actually expects a string.This PR tests for
undefinedandnull, where it'll pass an empty string. For all other values, it will convert to a string. As a result, ourAllowCreategets correctly set