samlcontent should be decrypted SAML response (sign then encrypt)#579
samlcontent should be decrypted SAML response (sign then encrypt)#579mastermatt wants to merge 4 commits intotngan:masterfrom
Conversation
|
@tngan @ahacker1-securesaml I've updated tests for this small change. |
ahacker1-securesaml
left a comment
ahacker1-securesaml
left a comment
There was a problem hiding this comment.
looks good to me. as a note, users should not use samlContent for any securit purposes or use it for authentication details. it should be used for purely debugging purposes
|
I am not the maintainer of this library. But I messaged him on slack to take a look. You should look at sponsoring the library, https://github.com/sponsors/tngan |
* Refactor to support encrypted assertions - Update CHANGELOG.md * Refactor: move authenio to devDependencies * Upgrade xml-crypto to 6.1.2 * Fix: CHANGELOG.md
|
Hey @tngan could I bump you on this? I'm hoping to get a patch published. Let me know if I can help in anyway. |
|
@tngan I have some discretionary sponsorship funds available for a one-time contribution. Any chance you have time to get eyes on this soon? |
# Conflicts: # test/flow.ts
Passing a value that was parsed and re-stringified can mess up whitespace encodings.
3 participants
This is a copy of the changes in #575, with the addition of test updates.