feat(parser)!!: robust parsing for stored procedures#6955
Draft
feat(parser)!!: robust parsing for stored procedures#6955
Conversation
geooo109
commented
Feb 4, 2026
| "tsql": "DROP TABLE IF EXISTS #TempTableName", | ||
| "spark": "DROP TABLE IF EXISTS TempTableName", | ||
| "tsql": "IF NOT OBJECT_ID('tempdb.dbo.#TempTableName', 'U') IS NULL BEGIN DROP TABLE #TempTableName", | ||
| # "spark": "DROP TABLE IF EXISTS TempTableName", |
Collaborator
Author
There was a problem hiding this comment.
Need to fix broken transpilation.
Contributor
SQLGlot Integration Test ResultsComparing:
By Dialect
Overallmain: 10273 total, 8565 passed (pass rate: 83.4%), sqlglot version: sqlglot:geooo109/sp_tsql: 10273 total, 8567 passed (pass rate: 83.4%), sqlglot version: Difference: No change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds parsing support for TSQL stored procedures.
In order to chunkify the input, we use the semicolon as the delimiter.
Each statement of the procedure is expected to have a semicolon at the end.
If the
BEGIN/ENDis used for the batching of statements, theENDmust be followed by a semicolon again (if there are statements after it).The parentheses of
IF/WHILEstatements aren't kept to the transpiled output.Moreover, arbitrary nesting is supported for
IF/ELSEandWHILEstatements.