-
-
Notifications
You must be signed in to change notification settings - Fork 334
fix: update dependencies #3442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: update dependencies #3442
Conversation
📝 WalkthroughWalkthroughThe PR downgrades Netty dependencies from version 4.2.5.Final to 4.1.129.Final across multiple build configuration files, adds a global Netty version property with forced resolution strategy, updates the PostgreSQL Docker base image from 13.21 to 13.23, and bumps assertJ and Google Cloud BOM library versions. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docker/app/Dockerfile`:
- Around line 1-11: The Dockerfile pins an unavailable openjdk21 version; update
the RUN apk --no-cache add openjdk21=21.0.10_p7-r0 line to use a valid Alpine
3.22 package version (e.g., openjdk21-jre=21.0.8_p9-r0 or
openjdk21-jdk=21.0.7_p6-r0) so the image build won't fail—modify the RUN
instruction that installs openjdk21 to reference one of those available package
names/versions.
| FROM postgres:13.23-alpine3.22 | ||
|
|
||
| ENTRYPOINT [] | ||
|
|
||
| RUN apk --no-cache add openjdk21 | ||
| RUN apk --no-cache add libxml2 | ||
| RUN apk --no-cache upgrade \ | ||
| busybox=1.37.0-r20 \ | ||
| libcrypto3=3.5.5-r0 \ | ||
| libssl3=3.5.5-r0 | ||
|
|
||
| RUN apk --no-cache add openjdk21=21.0.10_p7-r0 | ||
| RUN apk --no-cache add libxml2=2.13.9-r0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
Alpine Linux 3.22 packages busybox libcrypto3 libssl3 openjdk21 libxml2
💡 Result:
Alpine Linux v3.22 package versions (per pkgs.alpinelinux.org; versions can vary by architecture, so examples below use x86_64 unless noted):
- busybox (main): 1.37.0-r20 [1]
- libcrypto3 (main, from openssl): 3.5.5-r0 [2]
- libssl3 (main, from openssl): 3.5.5-r0 [3]
- libxml2 (main): 2.13.9-r0 [4]
- openjdk21 (community):
- openjdk21-jre (x86_64): 21.0.8_p9-r0 [5]
- openjdk21-jdk (x86_64): 21.0.7_p6-r0 [6]
- some other v3.22 architectures already show 21.0.9_p10-r0 (example: ppc64le) [7]
Sources: [1] https://pkgs.alpinelinux.org/package/v3.22/main/x86/busybox, [2] https://pkgs.alpinelinux.org/package/v3.22/main/x86/libcrypto3, [3] https://pkgs.alpinelinux.org/package/v3.22/main/x86/libssl3, [4] https://pkgs.alpinelinux.org/package/v3.22/main/x86/libxml2, [5] https://pkgs.alpinelinux.org/package/v3.22/community/x86_64/openjdk21-jre, [6] https://pkgs.alpinelinux.org/package/v3.22/community/x86_64/openjdk21-jdk, [7] https://pkgs.alpinelinux.org/package/v3.22/community/ppc64le/openjdk21
Fix openjdk21 version pinning—21.0.10_p7-r0 does not exist in Alpine 3.22.
The pinned version for openjdk21 is not available in Alpine v3.22. Available versions in x86_64 are 21.0.8_p9-r0 (openjdk21-jre) or 21.0.7_p6-r0 (openjdk21-jdk). Update the pin to one of these available versions to prevent build failures. Other packages (busybox, libcrypto3, libssl3, libxml2) are correctly pinned.
🤖 Prompt for AI Agents
In `@docker/app/Dockerfile` around lines 1 - 11, The Dockerfile pins an
unavailable openjdk21 version; update the RUN apk --no-cache add
openjdk21=21.0.10_p7-r0 line to use a valid Alpine 3.22 package version (e.g.,
openjdk21-jre=21.0.8_p9-r0 or openjdk21-jdk=21.0.7_p6-r0) so the image build
won't fail—modify the RUN instruction that installs openjdk21 to reference one
of those available package names/versions.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.