Allow initialize google places SDK from javascript#261
Allow initialize google places SDK from javascript#261GregoryNative wants to merge 1 commit intotolu360:masterfrom
Conversation
|
There are should be added some notes as it will brake Android after migration |
|
This is a great improvement. It should really be merged onto master at some point. |
|
Hi @GregoryNative, this looks interesting, I have thought about this route too. I am sorry I have been away and just looking at this. I am working on releasing a v4, a week from now, at the latest. However, do you think the keys would be more secure in Js? Feel feel to chime in again with your replies to this though. Thank you for your contributions all the same. |
|
Hi, @tolu360 that's fine as we have react-native-config to use with. |
|
So @GregoryNative have you had any issues with your keys in Manifest files? I am leaning towards going with you as some users have reported Google Play Store flagging the current location in Gradle properties as less secure as well. |
|
As far as I know it's fine. I am not on project with usage of this lib anymore. But as least several months ago there were no issues @tolu360 |
I found this feature useful for me. Let me know if I need to add something else here.