fix(layer.js): remove unnecessary returns, to more-gracefully watch l…#365
Closed
coltonbrugger wants to merge 6 commits intotombatossals:masterfrom
coltonbrugger:master
Closed
fix(layer.js): remove unnecessary returns, to more-gracefully watch l…#365coltonbrugger wants to merge 6 commits intotombatossals:masterfrom coltonbrugger:master
coltonbrugger wants to merge 6 commits intotombatossals:masterfrom
coltonbrugger:master
Conversation
…ayer property changes Resolves #336
Collaborator
|
🤔 going to check this tomorrow on my codebase to verify nothing breaks. Actually I'm not quite sure why these return statements are in there. They have been there already when I took over maintenance of this project 😄. Thx for ur PR |
Collaborator
|
@AaGg1234 Could you maybe try to include these mods in our codebase to verify it doesn't break anything? |
When a layer was not fully instantiated (perhaps due to not being assigned "source" geojson yet), it is still listed as a layer to be destroyed, though the `olLayer` is undefined for it. This update avoids attempts to remove a layer that is undefined.
Author
|
Sorry, accidentally brough additional commits (related to other fixes and openlayers version upgrades). I'm not sure how to roll those back here. Let me know how to best handle. |
Collaborator
|
See #389 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ayer property changes
Resolves #336