-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Random tonlib::EngineConsoleClient-adjacent changes
#2117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DanShaders
wants to merge
4
commits into
ton-blockchain:testnet
Choose a base branch
from
DanShaders:engine-console-client-review
base: testnet
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Random tonlib::EngineConsoleClient-adjacent changes
#2117
DanShaders
wants to merge
4
commits into
ton-blockchain:testnet
from
DanShaders:engine-console-client-review
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
8d2aa9e to
da43f8d
Compare
|
FFIEventLoop::run_in_context doesn't actually spawn lambda in a different thread, it just sets some thread_local variables and calls the lambda inline.
FFIEventLoop does not spuriously unblock.
The old code assumed that SchedulerContext::stop does not correctly work when there are alive actors. However, my investigation into SchedulerContext::stop implementation revealed that it most likely works correctly and intuitively. Even if it doesn't, the solution we had did not fully guard us against bugs (since it did not wait child actors) and at best masked some race conditions.
da43f8d to
e74aa1a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tonlib::EngineConsoleClientwas accidentally merged with simplex even though the code was not meant to be seen by the world yet. This PR fixes stuff I was meaning to change before upstreaming the client.