add .git to regex to get git project root from worktree directory#77
Open
JimmyRowland wants to merge 1 commit intotoplenboren:masterfrom
Open
add .git to regex to get git project root from worktree directory#77JimmyRowland wants to merge 1 commit intotoplenboren:masterfrom
JimmyRowland wants to merge 1 commit intotoplenboren:masterfrom
Conversation
toplenboren
reviewed
Jun 23, 2022
Owner
toplenboren
left a comment
toplenboren
left a comment
There was a problem hiding this comment.
Just add tests and this feature would go into new release :-)
Thanks for the PR
JimmyRowland
commented
Jun 24, 2022
| const { version: packageVersion } = require('./package.json'); | ||
|
|
||
| // eslint-disable-next-line no-unused-vars | ||
| const fsMock = jest.mock('fs') |
Author
There was a problem hiding this comment.
fsMock needs to be in scope so that mockFsImplementation() can work properly.
toplenboren
approved these changes
Jun 26, 2022
Collaborator
|
@JimmyRowland Sorry, but could you do a rebase to resolve the conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.