Conversation
Contributor
Author
|
@bdarnell when you've got a moment, it would be great if you could have a quick look to see if I'm going in the direction you'd expect, both in the implementation and in the tests. It's relatively easy to make bigger changes while the added code is quite small. There are 2 main new classes:
Things I'm aware of that the tests should cover:
(I'm sure that's not exhaustive, just writing down what I can think of now) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic support for wrapping a tornado web
Applicationclass and serving HTTP requests through an ASGI server.This obviously needs tests, but I've been able to start a server and serve a basic request locally: