Use variable annotations to avoid None defaults#3575
Open
hauntsaninja wants to merge 2 commits intotornadoweb:masterfrom
Open
Use variable annotations to avoid None defaults#3575hauntsaninja wants to merge 2 commits intotornadoweb:masterfrom
hauntsaninja wants to merge 2 commits intotornadoweb:masterfrom
Conversation
PEP 526 landed in Python 3.5 which is quite dead now If this PR is welcome, let me know, and I can make more like it
Author
|
Thanks, fixed the issues! |
hauntsaninja
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEP 526 landed in Python 3.5 which is quite dead now
This PR focusses on modernising the ones that improve safety around None handling (currently some of these accesses can produce None that the type checker will not warn you about)
If this PR is welcome, let me know, and I can make some more type related modernisations