Fix Docker gateway IP detection for newer Docker versions#196
Open
fao89 wants to merge 1 commit intotox-dev:masterfrom
Open
Fix Docker gateway IP detection for newer Docker versions#196fao89 wants to merge 1 commit intotox-dev:masterfrom
fao89 wants to merge 1 commit intotox-dev:masterfrom
Conversation
Improve gateway IP detection in get_gateway_ip() to handle both legacy and newer Docker API formats: - Try legacy NetworkSettings.Gateway first for backwards compatibility - Fall back to Networks section for newer Docker versions - Iterate through all networks to find any available gateway - Maintain "0.0.0.0" fallback for cases where no gateway is found This resolves issues where newer Docker versions store network information in a different structure than the legacy format. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
2 tasks
Contributor
|
@dcrosta Any chance of this getting reviewed and merged? Happy to help in any way I can. I have a project that uses GitHub Actions runners are currently rolling out Docker 29 (started Feb 9, 2026 — see actions/runner-images#13474), which removed the deprecated top-level This causes tox-docker to crash with: During the rollout, this manifests as flaky failures since some runners have Docker 28 and some have Docker 29. Once the rollout completes, it will be a 100% failure rate for anyone using The |
This was referenced Feb 12, 2026
jonathangreen
added a commit
to ThePalaceProject/virtual-library-card
that referenced
this pull request
Feb 12, 2026
## Description Added `TOX_DOCKER_GATEWAY` environment variable to the test workflow to work around a `KeyError: 'Gateway'` failure in tox-docker when running on Docker 29+. Docker 29 [removed the deprecated top-level `NetworkSettings.Gateway` key](https://docs.docker.com/engine/release-notes/29/) from the container inspect API. tox-docker 5.0.0 relies on this key and crashes with a `KeyError`. Setting `TOX_DOCKER_GATEWAY=0.0.0.0` bypasses the broken lookup entirely. This became flaky starting Feb 12 as the [Docker 29 rollout](actions/runner-images#13474) to GitHub Actions runners progresses. Once complete, tests will fail 100% of the time without this fix. This workaround can be removed once [tox-docker merges the fix](tox-dev/tox-docker#196). Mirrors the fix applied in [circulation#3045](ThePalaceProject/circulation#3045) and [library-registry#862](ThePalaceProject/library-registry#862). ## Motivation and Context CI test runs are failing intermittently with: ``` tox_docker/plugin.py, line 53, in get_gateway_ip ip = container.attrs["NetworkSettings"]["Gateway"] or "0.0.0.0" KeyError: 'Gateway' ``` ## How Has This Been Tested? - CI will validate that tests pass with the workaround on Docker 29+ runners ## Checklist - [x] I have updated the documentation accordingly. - [x] All new and existing tests passed.
jonathangreen
added a commit
to ThePalaceProject/circulation
that referenced
this pull request
Feb 12, 2026
## Description Added `TOX_DOCKER_GATEWAY` environment variable to the test workflow to work around a `KeyError: 'Gateway'` failure in tox-docker when running on Docker 29+. Docker 29 [removed the deprecated top-level `NetworkSettings.Gateway` key](https://docs.docker.com/engine/release-notes/29/) from the container inspect API. tox-docker 5.0.0 relies on this key and crashes with a `KeyError`. Setting `TOX_DOCKER_GATEWAY=0.0.0.0` bypasses the broken lookup entirely. This became flaky starting Feb 12 as the [Docker 29 rollout](actions/runner-images#13474) to GitHub Actions runners progresses. Once complete, tests will fail 100% of the time without this fix. This workaround can be removed once [tox-docker merges the fix](tox-dev/tox-docker#196). Mirrors the fix applied in [library-registry#862](ThePalaceProject/library-registry#862). ## Motivation and Context CI test runs are failing intermittently with: ``` tox_docker/plugin.py, line 53, in get_gateway_ip ip = container.attrs["NetworkSettings"]["Gateway"] or "0.0.0.0" KeyError: 'Gateway' ``` ## How Has This Been Tested? - CI will validate that tests pass with the workaround on Docker 29+ runners ## Checklist - [x] I have updated the documentation accordingly. - [x] All new and existing tests passed.
jonathangreen
added a commit
to ThePalaceProject/library-registry
that referenced
this pull request
Feb 12, 2026
## Description Added `TOX_DOCKER_GATEWAY` environment variable to the test workflow to work around a `KeyError: 'Gateway'` failure in tox-docker when running on Docker 29+. Docker 29 [removed the deprecated top-level `NetworkSettings.Gateway` key](https://docs.docker.com/engine/release-notes/29/) from the container inspect API. tox-docker 5.0.0 relies on this key and crashes with a `KeyError`. Setting `TOX_DOCKER_GATEWAY=0.0.0.0` bypasses the broken lookup entirely. This became flaky starting Feb 12 as the [Docker 29 rollout](actions/runner-images#13474) to GitHub Actions runners progresses. Once complete, tests will fail 100% of the time without this fix. This workaround can be removed once [tox-docker merges the fix](tox-dev/tox-docker#196). ## Motivation and Context CI test runs on Python 3.14 (and occasionally 3.12/3.13) are failing intermittently with: ``` tox_docker/plugin.py, line 53, in get_gateway_ip ip = container.attrs["NetworkSettings"]["Gateway"] or "0.0.0.0" KeyError: 'Gateway' ``` ## How Has This Been Tested? - CI will validate that tests pass with the workaround on Docker 29+ runners ## Checklist - [x] I have updated the documentation accordingly. - [x] All new and existing tests passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve gateway IP detection in get_gateway_ip() to handle both legacy and newer Docker API formats:
This resolves issues where newer Docker versions store network information in a different structure than the legacy format.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com