Add functions for tox crate version information#477
Open
antis81 wants to merge 4 commits intotox-rs:masterfrom
Open
Add functions for tox crate version information#477antis81 wants to merge 4 commits intotox-rs:masterfrom
antis81 wants to merge 4 commits intotox-rs:masterfrom
Conversation
Member
|
Would you please explain what you are fixing by this PR? Can you add more context? Error messages? |
Author
|
Actually this feature is available in c-toxcore (for example here). The PR adds those API calls to the "tox" crate. Might be better suited in both "tox" and "tox_core" crate though. This allows to query and display (meta) information about the tox(_core) crate at runtime. |
kpp
requested changes
Dec 18, 2023
Pull Request Test Coverage Report for Build 7247588774
💛 - Coveralls |
Member
|
Ok good. Can you integrate these functions into Tox-node? |
Author
|
Okay I moved the version info into the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds functions to query and display the
toxcrate version during runtime.tox::tox_node::crate_version -> Stringtox::tox_node::crate_version_major -> u32tox::tox_node::crate_version_minor -> u32tox::tox_node::crate_version_patch -> u32