Relax ID matching for the misc_dev#351
Conversation
Detect STM32 and AVR8
| {0x0ba00077, {"ADIv5 JTAG-DP port", 4}}, | ||
| {0x06400041, {"STM32 Device", 5}}, | ||
| {0x0ff00ffe, {"ZynqMP dummy device", 12}}, |
There was a problem hiding this comment.
The idea here is to provides the full idcode to display exact device (ARM cortex A9 and A53 differs only by upper nibble).
With this modification openFPGALoader will no more able to deal with zynq7000 & zynqMP
| found = search_and_insert_device_with_idcode(tmp); | ||
| if (!found) /* if masked not found -> search for full */ | ||
| found = search_and_insert_device_with_idcode(tmp); | ||
|
|
There was a problem hiding this comment.
I'm not really happy by the original code because some devices (lattice) with high nibble equal to 0 matches wrong version.
I think both mask & unmask search must be switched, but I have to check to be sure to not introduces a regression.
But If you remove mask most of the devices will never been found because in the idcode list most of devices have highest nibble masked to match all revisions, only a few number of them have full idcode.
|
What about adding a per-vendor handling after looking for the exact match and before the misc match used to long? |
|
I have planned to convert the one big list to multiple list (one per vendor) yes. |
2 participants
Detect STM32
Example output: