Skip to content

refactor: Metadata type/strides refactor#4534

Open
wingertge wants to merge 6 commits intotracel-ai:mainfrom
wingertge:refactor/metadata
Open

refactor: Metadata type/strides refactor#4534
wingertge wants to merge 6 commits intotracel-ai:mainfrom
wingertge:refactor/metadata

Conversation

@wingertge
Copy link
Contributor

Pull Request Template

Checklist

  • Confirmed that cargo run-checks command has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Requires
tracel-ai/cubecl#1190
tracel-ai/cubek#92

Changes

Moves Shape into cubecl-zspace.
Migrates strides to new Strides type in cubecl-zspace, and combined metadata to Metadata.
Renames some Shape methods for more consistent semantics. Changed swap to swapped, with swap now mutating in place like Rust slices do. Same with permute to permuted.

Testing

Tests pass on all CubeCL backends except CPU (which is also broken on main due to a divide by zero).

Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Also had a look at the linked PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants