refactor: Metadata type/strides refactor#4534
Open
wingertge wants to merge 6 commits intotracel-ai:mainfrom
Open
refactor: Metadata type/strides refactor#4534wingertge wants to merge 6 commits intotracel-ai:mainfrom
wingertge wants to merge 6 commits intotracel-ai:mainfrom
Conversation
laggui
approved these changes
Feb 17, 2026
Member
laggui
left a comment
There was a problem hiding this comment.
LGTM!
Also had a look at the linked PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
cargo run-checkscommand has been executed.Related Issues/PRs
Requires
tracel-ai/cubecl#1190
tracel-ai/cubek#92
Changes
Moves
Shapeintocubecl-zspace.Migrates strides to new
Stridestype incubecl-zspace, and combined metadata toMetadata.Renames some
Shapemethods for more consistent semantics. Changedswaptoswapped, withswapnow mutating in place like Rust slices do. Same withpermutetopermuted.Testing
Tests pass on all CubeCL backends except CPU (which is also broken on main due to a divide by zero).