Skip to content

fix: decouple kernels feature from cubecl/std#86

Merged
laggui merged 3 commits intotracel-ai:mainfrom
antimora:fix/decouple-cubecl-std-from-kernels
Feb 10, 2026
Merged

fix: decouple kernels feature from cubecl/std#86
laggui merged 3 commits intotracel-ai:mainfrom
antimora:fix/decouple-cubecl-std-from-kernels

Conversation

@antimora
Copy link
Contributor

Summary

  • cubek-quant/std no longer enables cubecl/std

This prevents getrandom from being pulled into wasm32-unknown-unknown builds.

Motivation

cubek-quant/kernels enables std, which previously enabled cubecl/std -> cubecl-common/std -> rand/std -> getrandom. On wasm, getrandom 0.3 requires a configured backend, breaking builds.

Companion PRs:

See: tracel-ai/cubecl#1181

Test plan

  • Verify existing tests pass
  • Verify wasm builds work when combined with cubecl and burn fixes

cubek-quant/std no longer enables cubecl/std, preventing getrandom from
being pulled into wasm32-unknown-unknown builds.

See: tracel-ai/cubecl#1181
@antimora
Copy link
Contributor Author

@laggui

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should update the cubecl rev in the Cargo.toml now that the linked PR was merged!

antimora and others added 2 commits February 10, 2026 12:39
Point cubecl deps to rev 6e988fd3 which includes the std
feature decoupling fix (cubecl#1184). Upgrade rand from 0.9
to 0.10 to match cubecl's new rand version.
@laggui laggui merged commit 61652dd into tracel-ai:main Feb 10, 2026
3 checks passed
antimora added a commit to antimora/burn-onnx that referenced this pull request Feb 10, 2026
Remove the getrandom wasm_js dep and burn-store/std feature.
These are no longer needed after upstream fixes in cubecl
(tracel-ai/cubecl#1184) and cubek (tracel-ai/cubek#86) that
stop unconditional std feature propagation.

Fixes tracel-ai#135
antimora added a commit to antimora/burn-onnx that referenced this pull request Feb 11, 2026
Remove the getrandom wasm_js dep and burn-store/std feature.
These are no longer needed after upstream fixes in cubecl
(tracel-ai/cubecl#1184) and cubek (tracel-ai/cubek#86) that
stop unconditional std feature propagation.

Fixes tracel-ai#135
antimora added a commit to tracel-ai/burn-onnx that referenced this pull request Feb 11, 2026
…trandom workaround (#144)

* fix: remove getrandom workaround from wasm example

Remove the getrandom wasm_js dep and burn-store/std feature.
These are no longer needed after upstream fixes in cubecl
(tracel-ai/cubecl#1184) and cubek (tracel-ai/cubek#86) that
stop unconditional std feature propagation.

Fixes #135

* fix: update burn dep to include rand 0.10 upgrade

Point burn deps at antimora/burn@6d0c9bd which includes the rand 0.9
to 0.10 upgrade. This resolves the getrandom 0.3 issue on
wasm32-unknown-unknown since the upstream cubecl/cubek fixes now
properly propagate through burn.

Also removes the --cfg getrandom_backend="wasm_js" workaround from
build-for-web.sh since it is no longer needed.

* fix: point burn deps at merged rand 0.10 PR and remove unused wasm deps

Update burn dependency from fork to tracel-ai/burn merged commit
(PR #4500) which includes the rand 0.10 upgrade. Also remove unused
serde_json and js-sys dependencies from image-classification-web.

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants