fix: decouple kernels feature from cubecl/std#86
Merged
laggui merged 3 commits intotracel-ai:mainfrom Feb 10, 2026
Merged
Conversation
cubek-quant/std no longer enables cubecl/std, preventing getrandom from being pulled into wasm32-unknown-unknown builds. See: tracel-ai/cubecl#1181
This was referenced Feb 10, 2026
Contributor
Author
laggui
reviewed
Feb 10, 2026
Member
laggui
left a comment
There was a problem hiding this comment.
Should update the cubecl rev in the Cargo.toml now that the linked PR was merged!
Point cubecl deps to rev 6e988fd3 which includes the std feature decoupling fix (cubecl#1184). Upgrade rand from 0.9 to 0.10 to match cubecl's new rand version.
…-std-from-kernels
antimora
added a commit
to antimora/burn-onnx
that referenced
this pull request
Feb 10, 2026
Remove the getrandom wasm_js dep and burn-store/std feature. These are no longer needed after upstream fixes in cubecl (tracel-ai/cubecl#1184) and cubek (tracel-ai/cubek#86) that stop unconditional std feature propagation. Fixes tracel-ai#135
6 tasks
antimora
added a commit
to antimora/burn-onnx
that referenced
this pull request
Feb 11, 2026
Remove the getrandom wasm_js dep and burn-store/std feature. These are no longer needed after upstream fixes in cubecl (tracel-ai/cubecl#1184) and cubek (tracel-ai/cubek#86) that stop unconditional std feature propagation. Fixes tracel-ai#135
antimora
added a commit
to tracel-ai/burn-onnx
that referenced
this pull request
Feb 11, 2026
…trandom workaround (#144) * fix: remove getrandom workaround from wasm example Remove the getrandom wasm_js dep and burn-store/std feature. These are no longer needed after upstream fixes in cubecl (tracel-ai/cubecl#1184) and cubek (tracel-ai/cubek#86) that stop unconditional std feature propagation. Fixes #135 * fix: update burn dep to include rand 0.10 upgrade Point burn deps at antimora/burn@6d0c9bd which includes the rand 0.9 to 0.10 upgrade. This resolves the getrandom 0.3 issue on wasm32-unknown-unknown since the upstream cubecl/cubek fixes now properly propagate through burn. Also removes the --cfg getrandom_backend="wasm_js" workaround from build-for-web.sh since it is no longer needed. * fix: point burn deps at merged rand 0.10 PR and remove unused wasm deps Update burn dependency from fork to tracel-ai/burn merged commit (PR #4500) which includes the rand 0.10 upgrade. Also remove unused serde_json and js-sys dependencies from image-classification-web. * Update README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cubek-quant/stdno longer enablescubecl/stdThis prevents
getrandomfrom being pulled intowasm32-unknown-unknownbuilds.Motivation
cubek-quant/kernelsenablesstd, which previously enabledcubecl/std->cubecl-common/std->rand/std->getrandom. On wasm,getrandom 0.3requires a configured backend, breaking builds.Companion PRs:
See: tracel-ai/cubecl#1181
Test plan