Skip to content

fix(vertexai): add error logging to instrumented functions #3624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kxbnb wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(vertexai): add error logging to instrumented functions #3624

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9272570
fix(vertexai): add error logging to instrumented functions
kxbnb Jan 20, 2026
c8de468
fix(vertexai): add error handling to streaming response handlers
kxbnb Jan 20, 2026
79c01bc
fix(vertexai): pass complete_response instead of generator to handler
kxbnb Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions ...opentelemetry-instrumentation-vertexai/opentelemetry/instrumentation/vertexai/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
)
from opentelemetry.trace import SpanKind, get_tracer
from opentelemetry.trace.status import Status, StatusCode
from opentelemetry.semconv.attributes.error_attributes import ERROR_TYPE
from wrapt import wrap_function_wrapper

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -245,7 +246,14 @@ async def _awrap(tracer, event_logger, to_wrap, wrapped, instance, args, kwargs)

await _handle_request(span, event_logger, args, kwargs, llm_model)

response = await wrapped(*args, **kwargs)
try:
response = await wrapped(*args, **kwargs)
except Exception as e:
span.set_attribute(ERROR_TYPE, e.__class__.__name__)
span.record_exception(e)
span.set_status(Status(StatusCode.ERROR, str(e)))
span.end()
raise

if response:
if is_streaming_response(response):
Expand Down Expand Up @@ -299,7 +307,14 @@ def _wrap(tracer, event_logger, to_wrap, wrapped, instance, args, kwargs):
else:
set_input_attributes_sync(span, args)

response = wrapped(*args, **kwargs)
try:
response = wrapped(*args, **kwargs)
except Exception as e:
span.set_attribute(ERROR_TYPE, e.__class__.__name__)
span.record_exception(e)
span.set_status(Status(StatusCode.ERROR, str(e)))
span.end()
raise

if response:
if is_streaming_response(response):
Expand Down