[e2e] check if UE traffic with non-assigned IP address is not passing.#303
Open
sergeymatov wants to merge 1 commit intomasterfrom
Open
[e2e] check if UE traffic with non-assigned IP address is not passing.#303sergeymatov wants to merge 1 commit intomasterfrom
sergeymatov wants to merge 1 commit intomasterfrom
Conversation
RoadRunnr
requested changes
Nov 22, 2022
Member
RoadRunnr
left a comment
RoadRunnr
left a comment
There was a problem hiding this comment.
The description of the changeset is invalid.
A UPF should do that the PDRs and FARs tell it to do. If the PDRs permit IPs other then the UE IP, then it is the job of the UPF to forward them. It has not bussines to infer rules that are not setup by the control path.
There are valid use cases, where devices behind a UE send data with source IPs that do not match the UEs IP.
That does not mean the the test is invalid. Ensuring that only source IPs matched by PDRs/FARs are forwarded is a valid check.
However, it would be possible to create PDRs/FARs that permit additional IP ranges as source IPs. In that case, those IPs should be forwarded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.