Skip to content

[WiP] Add startup script with worker core support#75

Open
ivan4th wants to merge 2 commits intomasterfrom
feature/multicore-startup-script
Open

[WiP] Add startup script with worker core support#75
ivan4th wants to merge 2 commits intomasterfrom
feature/multicore-startup-script

Conversation

@ivan4th
Copy link
Contributor

@ivan4th ivan4th commented Feb 9, 2021

Non-empty value of VPP_USE_WORKER_CORE env var enables the use of the
worker core. In this case, exactly 2 logical cores must be allocated
for the VPP container via the cpuset cgroup controller.

  • initial version of the script
  • verify that it's working for "classic" (workers 0) case
  • verify that it's working for "multicore" test
  • merge Fix stopping PFCP timers #83 and update this PR to remove extra commit
  • remove -x from #!/bin/bash in the start.sh

start.sh Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing indentation in echo value.

start.sh Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big 👍 fot this sleep!

@ivan4th ivan4th force-pushed the feature/multicore-startup-script branch 2 times, most recently from ddde293 to ea49a88 Compare February 10, 2021 10:07
Copy link

@jellonek jellonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ivan4th and others added 2 commits February 18, 2021 11:13
There was a corner case of timers "firing" after being stopped because
their "user handles" being already collected into the 'expires' vector
in pfcp_process(). This caused msg_pool corruption.
Non-empty value of VPP_USE_WORKER_CORE env var enables the use of the
worker core. In this case, exactly 2 logical cores must be allocated
for the VPP container via the cpuset cgroup controller.
@ivan4th ivan4th force-pushed the feature/multicore-startup-script branch from ea49a88 to b736a69 Compare February 18, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants