Allow for specifying custom VM type via compound group value#582
Open
meatballhat wants to merge 4 commits intomasterfrom
Open
Allow for specifying custom VM type via compound group value#582meatballhat wants to merge 4 commits intomasterfrom
meatballhat wants to merge 4 commits intomasterfrom
Conversation
The GCE provider uses an ACCOUNT_JSON variable to fetch the credentials for accessing the GCE API. This variable can either be a path to the JSON or a string of the JSON. A similar implementation is used in gcloud-cleanup. In worker, the provider config is processed and all config variables are 'unescaped' as if it was a URL. This causes the JSON to become unusable, mainly because the private key contains `+` symbols which get replaced by spaces. This solution simply checks if the key ends with ACCOUNT_JSON and skips the 'unescape' step. This ensures backwards compatibility for any other variables relying on this behavior. Ideally we should only run this step when required, as in 'variable is a URL that needs unescaping'.
Miguelzamora13
approved these changes
Oct 31, 2023
Miguelzamora13
approved these changes
Oct 31, 2023
Miguelzamora13
approved these changes
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a short-term hack that is not intended to be merged in current form. For more info, please holler at @meatballhat.