fix: Update build constraints to include FreeBSD#45
Open
seuros wants to merge 1 commit intotree-sitter:masterfrom
Open
fix: Update build constraints to include FreeBSD#45seuros wants to merge 1 commit intotree-sitter:masterfrom
seuros wants to merge 1 commit intotree-sitter:masterfrom
Conversation
Member
|
What about other BSDs? :) |
Author
|
I dont have the other bsds installed to test. With Freebsd, it works.. the others bsd need manual testing to assure it can compile. Or we can just reverse the condition by banning no unix system. |
Author
|
@ObserverOfTime What the decision here ? Should i add others YOLO way ? or just have unix .. |
Member
|
I don't make the decisions and I can't merge, I was just asking. |
|
Plus one here, can we have this? |
|
Who can make those decisions @ObserverOfTime ? Is it @amaanq ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While compiling ore in freebsd, i noticed tag is missing.