This repository was archived by the owner on Nov 23, 2021. It is now read-only.
Change regex style to account for no matches#11
Open
andrew-carroll wants to merge 1 commit intotrek:masterfrom
andrew-carroll:issue5_nil_capture_fix
Open
Change regex style to account for no matches#11andrew-carroll wants to merge 1 commit intotrek:masterfrom andrew-carroll:issue5_nil_capture_fix
andrew-carroll wants to merge 1 commit intotrek:masterfrom
andrew-carroll:issue5_nil_capture_fix
Conversation
Owner
|
Can you add a spec for the cases where this helps? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #5 . Old code would sometime not match anything, and match annoyingly returns nil when there are no matches. The alternate regex matching syntax, featured in the new commit, is more forgiving, returning instead an empty set.