Skip to content

Conversation

@9albi
Copy link

@9albi 9albi commented Jul 17, 2024

fixed one of the json keys 'channel_name' => 'channelName'

additionally I've reordered the assertion arguments as it should be of the form : assert.Equal(t, expected, result)

Copy link
Contributor

@johan1252 johan1252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for the contribution!

Once #78 merges, this PR should succeed as well.
Have also raised so these tests run as part of Github Action - #80

fixed one of the json keys 'channel_name' => 'channelName'

additionally I've reordered the assertion arguments as it should be of the form :
`assert.Equal(t, expected, result)`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants