Skip to content

Rework particle packing #732

Merged
LasNikas merged 49 commits intotrixi-framework:mainfrom
LasNikas:rework-particle-packing
May 7, 2025
Merged

Rework particle packing #732
LasNikas merged 49 commits intotrixi-framework:mainfrom
LasNikas:rework-particle-packing

Conversation

@LasNikas
Copy link
Collaborator

No description provided.

@LasNikas LasNikas requested review from efaulhaber and svchb March 11, 2025 14:16
@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 62.22222% with 34 lines in your changes missing coverage. Please review.

Project coverage is 70.61%. Comparing base (46e0022) to head (e5675b7).

Files with missing lines Patch % Lines
src/preprocessing/particle_packing/system.jl 43.47% 26 Missing ⚠️
src/preprocessing/particle_packing/nhs_faces.jl 0.00% 2 Missing ⚠️
src/preprocessing/particle_packing/rhs.jl 0.00% 2 Missing ⚠️
.../preprocessing/particle_packing/signed_distance.jl 91.66% 2 Missing ⚠️
src/setups/complex_shape.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
+ Coverage   70.29%   70.61%   +0.31%     
==========================================
  Files         103      103              
  Lines        6574     6618      +44     
==========================================
+ Hits         4621     4673      +52     
+ Misses       1953     1945       -8     
Flag Coverage Δ
unit 70.61% <62.22%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LasNikas LasNikas self-assigned this Mar 11, 2025
@LasNikas LasNikas force-pushed the rework-particle-packing branch from c44a5d8 to 54a7cb3 Compare March 17, 2025 10:17
@svchb
Copy link
Collaborator

svchb commented Mar 26, 2025

@LasNikas The test coverage is too low this should also cover these functions:

  • function volume(polygon::Polygon)
  • function volume(mesh::TriangleMesh)
  • function constrain_particles_onto_surface!(u, system::ParticlePackingSystem)
  • function ParticlePackingSystem(shape::InitialCondition;....

@LasNikas LasNikas force-pushed the rework-particle-packing branch from a0b1696 to 0652a0b Compare April 1, 2025 11:08
@LasNikas LasNikas force-pushed the rework-particle-packing branch from 13a4953 to c234ea5 Compare April 8, 2025 16:36
…packing"

This reverts commit a14a921, reversing
changes made to 9763ea5.
@efaulhaber
Copy link
Member

Tests are failing.

@LasNikas LasNikas requested a review from efaulhaber April 30, 2025 10:05
@LasNikas LasNikas requested a review from svchb April 30, 2025 12:23
@LasNikas LasNikas requested a review from efaulhaber May 5, 2025 15:22
@efaulhaber
Copy link
Member

/run-gpu-tests

@LasNikas LasNikas enabled auto-merge (squash) May 7, 2025 09:10
@LasNikas LasNikas merged commit fb6906f into trixi-framework:main May 7, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments