Add variable smoothing length#736
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
==========================================
- Coverage 69.98% 69.95% -0.04%
==========================================
Files 96 96
Lines 6170 6203 +33
==========================================
+ Hits 4318 4339 +21
- Misses 1852 1864 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d847bd8 to
7266c4a
Compare
8fab9e6 to
9d58ec6
Compare
svchb
left a comment
There was a problem hiding this comment.
In its current form it breaks:
- corrections
pressure_acceleration needs to be adjusted.
|
wcsph/rhs.jl: grad_kernel = smoothing_kernel_grad(particle_system, pos_diff, distance, particle) |
|
The Test Summary: | Pass Fail Total Time
dam_break_2d.jl with corrections | 33 3 36 1m31.7s
continuity_reinit | 3 3 7.7s
gradient_continuity_correction | 3 3 7.0s
gradient_summation_correction | 3 3 7.6s
no_correction | 3 3 5.3s
shepard_kernel_correction | 3 3 6.8s
blended_gradient_continuity_correction | 3 3 7.0s
mixed_kernel_gradient_summation_correction | 2 1 3 12.2s
akinci_free_surf_correction | 3 3 5.5s
kernel_correction_summation_correction | 2 1 3 7.7s
mixed_kernel_gradient_continuity_correction | 2 1 3 9.5s
kernel_correction_continuity_correction | 3 3 7.4s
blended_gradient_summation_correction | 3 3 7.7s |
2f00fa8 to
fa8d8a9
Compare
95d8c46 to
ba6f08b
Compare
|
/run-gpu-tests |
|
/run-gpu-tests |
|
/run-gpu-tests |
Preparation for #735 and #652