fix: use correct CSS variable to control bar chart background color#27
Merged
fix: use correct CSS variable to control bar chart background color#27
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the wrong CSS variable name was used to control the bar chart background color for precipitation. The code was incorrectly referencing --wfc-chart-precipitation-bar-color, but the actual CSS variable defined in the stylesheet is --wfc-precipitation-bar-color.
- Fixed the CSS variable reference from
--wfc-chart-precipitation-bar-colorto--wfc-precipitation-bar-color - Added comprehensive test coverage to verify all CSS variables are correctly applied to the chart configuration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/wfc-forecast-chart.ts | Corrected the CSS variable name from --wfc-chart-precipitation-bar-color to --wfc-precipitation-bar-color to match the actual variable defined in the stylesheet |
| test/weather-forecast-chart.test.ts | Added a new test case to verify that all CSS custom properties are properly respected and applied to chart elements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.