fix: implement hard limit for canvas width when using forecast mode#48
Merged
fix: implement hard limit for canvas width when using forecast mode#48
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a hard limit on canvas width to prevent rendering errors when displaying large forecast datasets in chart mode. The implementation addresses browser canvas size limitations by truncating forecast data to fit within a 16384-pixel width constraint.
Key Changes:
- Introduces a
MAX_CANVAS_WIDTHconstant (16384px) and asafeForecastgetter that truncates forecast data when necessary - Updates all chart-related methods to use the truncated forecast data instead of the raw forecast property
- Adds comprehensive test coverage for the truncation logic with a 500-item forecast scenario
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/components/wfc-forecast-chart.ts | Implements canvas width limiting by adding MAX_CANVAS_WIDTH constant, safeForecast getter with gap-aware calculation, and updates render/chart methods to use truncated data |
| test/weather-forecast-chart.test.ts | Adds test case verifying 500-item forecast is correctly truncated to 327 items based on itemWidth=50 and gap=0 |
| README.md | Documents the 16384px canvas width limitation and explains that forecast data exceeding this limit will be truncated |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Tero Roininen <troinine@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Tero Roininen <troinine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40