Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the fade mask (gradient overlay) was always applied to the forecast container, even when the content wasn't scrollable. The fix adds logic to detect when the forecast container is scrollable and conditionally applies the mask CSS only in those cases.
Key changes:
- Added scrollability detection logic that compares the number of forecast items to the calculated items that fit in the viewport
- Conditionally applied the
is-scrollableCSS class using Lit'sclassMapdirective - Restructured CSS to only apply mask styles when the container is scrollable
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/weather-forecast-card.ts | Added _isScrollable state property, imported classMap directive, implemented logic to detect scrollable state in layoutForecastItems, and conditionally applied the is-scrollable class to the forecast container |
| src/weather-forecast-card.css | Moved mask-related CSS properties into a new .wfc-forecast-container.is-scrollable selector, keeping pointer-events: auto on the base container class |
| test/weather-forecast-card.test.ts | Added comprehensive test to verify the is-scrollable class and _isScrollable property are correctly toggled based on whether content overflows the container |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.