This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Allow coercion when given union of coercible values#427
Open
sebinsua wants to merge 1 commit intotrpc:masterfrom
Open
Allow coercion when given union of coercible values#427sebinsua wants to merge 1 commit intotrpc:masterfrom
sebinsua wants to merge 1 commit intotrpc:masterfrom
Conversation
sebinsua
commented
Dec 12, 2023
sebinsua
commented
Dec 12, 2023
sebinsua
changed the title
sebinsua
force-pushed
the
allow-union-or-intersection-coercion-when-possible
branch
from
2ff14b5 to
5af397a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A value is coercible if it itself is coercible or if it is a union of only coercible values.
This is somewhat related to #255 but only improves upon unions by avoiding the error and supporting coercions. It doesn't add support for discriminated unions, as according to the issue linked to, these lack upstream support within OpenAPI (???).
Note: I originally wrote some code to support intersections in the same way but I've removed this because I don't have a practical example of when it would make sense.