Rework system dataset migration to be less bad #18006
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anodos325
force-pushed
the
improve-sysdataset4
branch
from
d35f5fd to
a796308
Compare
This commit reworks how we migrate the system datasets so that it's somewhat less racy and uses kernel APIs for this. On migration: 1. build new mount tree in middleware run dir 2. sync data from old to new 3. move new under old 4. move old to middleware rundir 5. restart services 6. cleanup
anodos325
force-pushed
the
improve-sysdataset4
branch
from
42867d6 to
84878f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reworks how we migrate the system datasets so that it's somewhat less racy and uses kernel APIs for this.
On migration: