NAS-139300 / 26.0.0-BETA.1 / Add dataset and relative_path fields to share entries

[creatorcary]

This represents the first change for NAS-137337. We may choose to do something similar for other services that use dataset paths.

• Add "dataset" field which is calculated on create and update based on "path"
• Add "relative_path" field which is calculated on create and update based on "path"
• Keep "path" field to avoid concatenating the fields and prepending "/mnt/" when the full path is required
• No extra mess in extend and compress

1. Alembic migration adds columns to all SharingServiceTask services.
2. migration/0018 attempts to populate the columns based on the existing path fields.
3. pool.import and pool.dataset.unlock call hooks to query unresolved share paths and attempt to resolve them.

http://jenkins.eng.ixsystems.net:8080/job/tests/job/api_tests/7557/

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-139300

[creatorcary]

friendly ping @anodos325 @sonicaj

[claude]

🤖 Claude is monitoring this PR

I'll review code, respond to comments, and investigate CI failures.
Start any comment with (skip) to have me ignore it.

• Push fix commits (uncheck to only post review comments)

[anodos325]

We should also probably give directive to use the etc plugin framework when generating config files. That means creating files in etc_files dir (should have one per file generated -- .py scripts should return bytes of file). Once etc files have been created then it should be inserted into appropriate etc plugin group (plugins/etc.py) for the particular area of code.

Also note to claude that atomic_write() should be used whenever there is a risk of data race on a file that would result in undefined application behavior.

[themylogin]

I feel like this file is a little bit too long. In my experience, even 50-line CLAUDE.md gets blatantly ignored.

Do you use makefiles in your workflow for example?

etc files-related things should definitely go to CLAUDE.md inside etc files directory.

[creatorcary]

I created the file with claude init and then prompted claude to make any additions or amendments. I try not to edit memory files manually, figuring the agent knows what format it prefers to read from. The headings and subheadings should help it find the relevant info it needs, even for larger files.

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.