Skip to content

values.schema.json: fix priorityClass validation #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j2fw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

values.schema.json: fix priorityClass validation #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions trufflehog/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,25 +463,12 @@
"if": {
"properties": {
"create": {
"const": false
"const": true
}
}
},
"then": {
"properties": {
"name": {
"type": "string",
"minLength": 1
}
},
"required": ["name"]
},
"else": {
"properties": {
"value": {
"type": "integer"
}
}
"required": ["name", "value"]
Copy link

@cursor cursor bot Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect validation logic for priorityClass fields

The validation requires name when create is true, but the name field description states it's for "Existing priority class to use if create is false". When creating a priority class, name shouldn't be required; when using an existing one (create: false), name should be required instead of value.

Fix in Cursor Fix in Web

}
},
"securityContext": {
Expand Down