Draft
Conversation
Previously, some internals of the pipe module were public, while parts of the public interface where only pub(crate). This patch fixes visibility in the pipe module so that internals are private and the public API is public. It also fixes some clippy lints on the way.
Instead of resetting the pipe state after sending the error, we can direclty write it to the endpoint as it will always fit into one init packet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts a
Bufferstruct fromPipethat takes care of message fragmentation and dispatch, whilePipeimplements the USB communication. This allows us to use the message buffer in other contexts, for example for unit tests, and also makes it possible to test and fuzz its functionality directly.