Fixed color code revering issues and allow it to run on python 3.8.x #4
Conversation
Fixed(?) how smi style color code converted to ass style. Changed and test to run on python 3.8.x on linux_x86-64 and arm Also, changed to not add "kor" on the end of the file when there is no other language is depicted. Also, add to print what file is currently working on. Also, some setting update.
On the original code, the cover conversion from smi to ass was wrong. It add new function that converting RGB to BGR
trustin
left a comment
trustin
left a comment
There was a problem hiding this comment.
Thank you so much for your contribution!
Could you also revert the file mode changes in the .sh files?
| /build | ||
| /test_smis/*.ass | ||
| __pycache__ | ||
| .vscode No newline at end of file |
There was a problem hiding this comment.
Yes, this is automatically added by my IDE setting.
| else: | ||
| print ('version 3.x needed') | ||
|
|
||
| default_lang_code = 'kor' |
There was a problem hiding this comment.
Could you let me know why this had to be removed?
There was a problem hiding this comment.
I thought if the subtitle file only incused single language in the subtitle it is meaningless to add kor on the file name. Since already know what language is in the subtitle file.
|
|
||
| default_lang_code = 'kor' | ||
| default_font_name = 'sans-serif' | ||
| default_font_name = 'Malgun Gothic' |
There was a problem hiding this comment.
How about using fonts like "Noto Sans CJK KR" instead, given Malgun Gothic is not available in non-Windows?
There was a problem hiding this comment.
This is part of my mistake, while using and testing this program, I modified the ass to match with my subtitle settings.
2 participants
Fixed(?) how smi style color code converted to ass style.
Changed and test to run on python 3.8.x on linux_x86-64 and arm Also, changed to not add "kor" on the end of the file when there is no other language is depicted.
Also, add to print what file is currently working on.
Also, some setting updates.