feat:OpenAPI deprecations and clarify image_url base64 or URL in SDK#300
feat:OpenAPI deprecations and clarify image_url base64 or URL in SDK#300
Conversation
WalkthroughThe OpenAPI spec at src/libs/Cohere/openapi.yaml was updated to add deprecation markers to multiple endpoints and response components, particularly service-unavailable and gateway-timeout responses. Public SDK code samples were updated with comments clarifying that image_url may be a base64 data URI or a web URL. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/libs/Cohere/openapi.yaml (1)
8772-8787: Examples improved; align model IDs across languagesThe “base64 data URI or web URL” comments are helpful. Minor nit: TS/Python/Java use
command-a-vision-07-2025, while Go usescommand-a-03-2025. Consider standardizing to one model to avoid confusion.- Model: "command-a-03-2025", + Model: "command-a-vision-07-2025",Please confirm that
imageUrl(TS/Java/Go) vsimage_url(Python/cURL) is the intended SDK-specific casing.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (21)
src/libs/Cohere/Generated/Cohere.CohereClient.Chat.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.CohereClient.Classify.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.CohereClient.Generate.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.CohereClient.Summarize.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.ConnectorsClient.CreateConnector.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.ConnectorsClient.DeleteConnector.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.ConnectorsClient.GetConnector.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.ConnectorsClient.ListConnectors.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.ConnectorsClient.OAuthAuthorizeConnector.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.ConnectorsClient.UpdateConnector.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.ICohereClient.Chat.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.ICohereClient.Classify.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.ICohereClient.Generate.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.ICohereClient.Summarize.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.IConnectorsClient.CreateConnector.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.IConnectorsClient.DeleteConnector.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.IConnectorsClient.GetConnector.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.IConnectorsClient.ListConnectors.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.IConnectorsClient.OAuthAuthorizeConnector.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.IConnectorsClient.UpdateConnector.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.Models.ChatRequest.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/Cohere/openapi.yaml(12 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test / Build, test and publish
🔇 Additional comments (11)
src/libs/Cohere/openapi.yaml (11)
168-174: Property-level deprecation LGTM; add guidance to consumersThe boolean schema placement is correct. Consider adding a brief “Deprecated: use X instead” note to the description to help SDK users, and ensure changelog/docs reflect the deprecation.
1004-1010: Operation-level deprecation LGTM
deprecated: trueat the operation level is valid. Ensure replacement endpoint is documented in the operation description or external docs.
1128-1134: Consistent deprecation across operationsLooks good and consistent with hunk 3.
1198-1204: LGTMNo issues spotted.
1271-1277: LGTMOperation correctly marked deprecated.
1343-1349: LGTMConsistent with prior hunks.
1421-1427: LGTMNo structural issues.
1501-1507: LGTMDeprecation placement is correct.
6623-6629: LGTMConsistent application.
7178-7184: LGTMAll good here.
63-69: Incorrect —deprecatedalready on the array property; no change required
In src/libs/Cohere/openapi.yaml theconnectorsentry hasitems: $ref(lines 63–64) whiledescriptionanddeprecated: trueare applied to the array/property (lines 65–66). No change needed.Likely an incorrect or invalid review comment.
Summary by CodeRabbit
Documentation
Chores