-
Notifications
You must be signed in to change notification settings - Fork 249
[comp] Production Deploy #2110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[comp] Production Deploy #2110
Conversation
* feat(tasks): add framework instances support to task filtering * feat(tasks): define FrameworkInstanceForTasks type for task components and added a handler for non-existent frameworks * feat(tasks): add validation for frameworkFilter in TaskList component --------- Co-authored-by: Lewis Carhart <lewis@trycomp.ai>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryHigh Risk Overview Introduces review-request notifications (email + in-app via Novu) with new Enhances the task UI with an approver selector, submit/approve/reject UX, and a new Activity tab backed by a Includes several UI migrations/refactors to Written by Cursor Bugbot for commit e0ae4dc. This will update automatically on new commits. Configure here. |
#2111) * feat(context): resolve framework IDs to human-readable names in context entries * refactor(auditor): exclude framework selection and auditor sections from context --------- Co-authored-by: Lewis Carhart <lewis@trycomp.ai>
* feat(context): resolve framework IDs to human-readable names in context entries * refactor(auditor): exclude framework selection and auditor sections from context * feat(people): enhance JoinDate component with date parsing and dropdown * refactor(people): simplify JoinDate component by removing date parsing logic * refactor(people): update label in JoinDate component to 'Join Date' * fix(people): add button type to Done button in JoinDate component --------- Co-authored-by: Lewis Carhart <lewis@trycomp.ai>
* feat(tasks): add email templates and notification logic for evidence review requests * fix(tasks): adjust layout of TabsContent in SingleTask component --------- Co-authored-by: Tofik Hasanov <annexcies@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 4 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| } | ||
|
|
||
| const updatedCount = response.data?.updatedCount ?? selectedTaskIds.length; | ||
| toast.success(`${updatedCount} task${updatedCount === 1 ? '' : 's'} submitted for review`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Response field name mismatch breaks task count display
Medium Severity
The frontend expects updatedCount in the response from the bulk submit-for-review endpoint, but the backend returns submittedCount. This causes response.data?.updatedCount to always be undefined, making the toast message fall back to selectedTaskIds.length instead of reflecting the actual number of tasks that were successfully submitted.
Additional Locations (1)
| ? `cancelled evidence review for ${assigneeName}` | ||
| : `rejected evidence by ${assigneeName}`, | ||
| data: { | ||
| action: isCancellation ? 'reject' : 'reject', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Audit log action always records 'reject' for cancellations
Medium Severity
In the rejectTask method, the audit log data.action field uses a ternary expression isCancellation ? 'reject' : 'reject' which always evaluates to 'reject'. When an admin/owner cancels a review (rather than the approver rejecting it), the audit trail cannot distinguish between the two different actions.
* chore(deps): update package versions and improve loading components * chore(deps): update cheerio, zod, and other package versions * style(FindingsOverview): update styling for no findings message and button * refactor(people): simplify member and invitation components with new design system, fixed findings on overview page, removed fade in from settings page, re-ordered tabs in trust center * refactor(ui): change onInput to onChange in QuantityInput component * chore(deps): update react-hook-form to version 7.71.1 * feat(secrets): enhance SecretsTable with search, pagination, and delete functionality --------- Co-authored-by: Lewis Carhart <lewis@trycomp.ai>


This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.