Skip to content

Conversation

@IAmABakuAMA
Copy link

This is a minor change that should, hopefully, fix an annoying to track down bug, #48.

The index.html file attempts to call "googleapi.com". The correct URL is "googleapis.com". The extension appears to fallback to a different font upon the failure, however on some VPNs, the incorrect URL will get stuck loading for ~10-20 seconds before falling back.

In the future, some additional error handling logic could be implemented to time the font request out after a few seconds. Theoretically, the extension would get stuck opening indefinitely if the font domain is ever unreachable but does not return an outright failure, although the browser would probably forcefully time it out after a little while. The font could also be bundled or cached locally so that it doesn't need to be fetched locally.

Testing

I have been able to consistently reproduce #48 by using Windscribe VPN and Firefox on Windows 11. It is difficult to reproduce, as it seems to be caused by an old cached ip for that googleapi.com domain. Either way, this probably doesn't require extensive tests, as the typo domain is a (minor) issue either way. I did confirm that this resolves #48 for me by cloning the repo locally, changing the domain, and loading the extension in Firefox.

Note

I didn't use any linter or IDE to make this change. I just used GitHub's built in code editor in the web GUI. I know last time this caused an issue with the linter, apologies if that happens again.

Correct a typo in a font URL, which lead to a delay in opening the extension under circumstances
@lamusmaser
Copy link

lgtm, single change on single line. Thanks for finding this. @bbilly1 for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot open extension popup

2 participants