Open
Conversation
byxorna
approved these changes
Aug 27, 2020
Contributor
byxorna
left a comment
byxorna
left a comment
There was a problem hiding this comment.
Thanks, this looks great! Also, props on unit tests :)
pkg/server/webhook.go
Outdated
| } | ||
|
|
||
| if injectionConfig.SkipHostNetwork && pod.Spec.HostNetwork { | ||
| glog.Infof("Injection skipped by SkipHostNetwork") |
Contributor
There was a problem hiding this comment.
[nit] maybe a more expressive message like "injection skipped due to pod using HostNetwork, and SkipHostNetwork is enabled for this sidecar"?
Author
There was a problem hiding this comment.
Thanks for your review! I've pushed a new commit which prints readable skipping reason, as well as the ns/name of the pod and the name of the sidecar config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Provide the ability to skip the injection for host network pods.
Some sidecars will run
ip rule,ip routeandiptablesto manipulate traffic to/from the sidecar. This might be dangerous if the pod is runninghostNetwork. It would be great if the injector configuration can be configured to skip the injection for host network pods, just like Istio.Testing Steps
make test)Reviewers
Required reviewers:
@byxornaRequest reviews from other people you want to review this PR in the "Reviewers" section on the right.