fix: add and remove inert attributes to allow browser proper focus management for modals#41867
Open
fix: add and remove inert attributes to allow browser proper focus management for modals#41867
Conversation
…nagement for modals. Addresses warnings logged in console about this behavior, see: twbs#41005 (comment)
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #41005 to get rid of the
aria-hiddennot applied warnings logged in the browser console.Example warning message:
EDIT: added explicit tests for this
inertattribute fixDescription
added
inertattribute to the modal on hide, remove it on showMotivation & Context
#41005
Type of changes
Checklist
npm run lint)Live previews
Related issues
#41005