Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables automatic stack size limit setting during R initialization and makes it opt-in via the H_INCREASE_STACK_SIZE environment variable. This is a breaking change that requires users who depend on the automatic stack limit increase to explicitly enable it.
Changes:
- Refactored stack limit setting into a separate
setLimitfunction with platform-specific implementations - Made stack limit setting conditional on the presence of
H_INCREASE_STACK_SIZEenvironment variable - Changed macOS behavior to only print a warning message instead of attempting to set the limit
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| inline-r/src/Language/R/Instance.hs | Refactored stack limit setting logic to be opt-in via environment variable, with platform-specific implementations for macOS, FreeBSD, Linux, and other systems |
| inline-r/CHANGELOG.md | Documents the breaking change for disabling automatic stack limit setting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
qnikst
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.