Skip to content

Re-introduce normalize#243

Draft
idontgetoutmuch wants to merge 1 commit intomasterfrom
put-normalize-back
Draft

Re-introduce normalize#243
idontgetoutmuch wants to merge 1 commit intomasterfrom
put-normalize-back

Conversation

@idontgetoutmuch
Copy link
Contributor

No description provided.

@turion
Copy link
Collaborator

turion commented Jan 11, 2023

Intends to close #241


-- | Normalizes the weights in the population so that their sum is 1.
normalize :: (Monad m) => Population m a -> Population m a
normalize = hoist unweighted . extractEvidence
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unweighted used to be called prior https://hackage.haskell.org/package/monad-bayes-0.1.1.0/docs/src/Control.Monad.Bayes.Population.html#normalize, so I guess this is the same implementation as before. Shouldn't we restore the comment about bias here?

@turion
Copy link
Collaborator

turion commented Jan 11, 2023

In test/TestInference.hs, you should hide the import normalize from Population

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments