Refactor extraction and caching of CabalInfo#1034
Open
brandonchinn178 wants to merge 2 commits intotweag:masterfrom
Open
Refactor extraction and caching of CabalInfo#1034brandonchinn178 wants to merge 2 commits intotweag:masterfrom
brandonchinn178 wants to merge 2 commits intotweag:masterfrom
Conversation
Member
|
I'm happy with the first commit, which I adjusted a bit to apply the new helper to both caching of cabal files and |
Collaborator
Author
|
Ah sure, I could make the changes backwards compatible. Give me a second |
da1c023 to
c0bf761
Compare
Collaborator
Author
|
@mrkkrp how's that? Also, there's a weeder failure. Maybe |
c0bf761 to
d589b1d
Compare
Member
|
Eh, I like splitting the code in two branches (old and new) even less. Let's apply d91bbd0 and keep the rest on the shelf for a while until we decide to release 0.8.0.0 at which point we can make a clean break. |
Collaborator
Author
|
Sure up to you |
d589b1d to
d575601
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broken off from #1033
This change has the following improvements:
CabalInforeturn all info for the cabal file, without reference to the source fileparseCabalInfoas just "parse cabal file", not "parse cabal file + extract info relevant to given source file"