Fix bug in chunksBetween, whereby the result was always empty or singleton#15
Open
vreuter wants to merge 4 commits intotweag:mainfrom
Open
Fix bug in chunksBetween, whereby the result was always empty or singleton#15vreuter wants to merge 4 commits intotweag:mainfrom
chunksBetween, whereby the result was always empty or singleton#15vreuter wants to merge 4 commits intotweag:mainfrom
Conversation
Closed
gdeest
approved these changes
Feb 9, 2026
gdeest
left a comment
gdeest
left a comment
There was a problem hiding this comment.
The properties make sense and obviously prevent any future regression. I can't think of any other reasonable property.
Author
|
It looks like the URL reference checks in the CI (Project checks / Check references) which are failing here are failing generally, overlapping e.g. with those in another recent PR and therefore have nothing to do with the changes here. |
vreuter
changed the title
chunksBetween, whereby the result was always emptychunksBetween, whereby the result was always empty or singleton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.