Add "html_attributes" twig filter for easiely write attributes as objects#3760
Closed
alexander-schranz wants to merge 3 commits intotwigphp:3.xfrom
Closed
Add "html_attributes" twig filter for easiely write attributes as objects#3760alexander-schranz wants to merge 3 commits intotwigphp:3.xfrom
alexander-schranz wants to merge 3 commits intotwigphp:3.xfrom
Conversation
stof
suggested changes
Oct 14, 2022
| return [ | ||
| new TwigFilter('data_uri', [$this, 'dataUri']), | ||
| new TwigFilter( | ||
| 'html_attributes', |
Member
There was a problem hiding this comment.
this looks more like a function than a filter to me
extra/html-extra/HtmlExtension.php
Outdated
| continue; | ||
| } | ||
|
|
||
| $htmlAttributes[] = $key . '="' . twig_escape_filter($environment, $value, 'html_attr') . '"'; |
| } | ||
|
|
||
| /** | ||
| * @param array{string, string|bool|int|float|null} $attributes |
Member
There was a problem hiding this comment.
wrong type. array{string, string|bool|int|float|null} means an array with 2 elements, with index 0 being a string and index 1 being string|bool|int|float|null. Instead, you should use array<string, string|bool|int|float|null>
Contributor
Contributor
|
Closing in favor of #3930 (which has the |
Contributor
Author
|
Make sense. Thx @mpdude 👍 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example usage:
TODO