feat!: Add secondary token support to Rack::TwilioWebhookAuthentication#600
Open
jsteinberg wants to merge 2 commits intotwilio:mainfrom
Open
Conversation
|
@jsteinberg are you still using a forked version of Twilio-ruby to accomplish this, just because nobody cares about giving feedback on this feature? |
Author
Not using a fork. We just implemented this manually in the controller instead of relying on the middleware provided by the gem. Its not a lot of code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Add support for multiple auth tokens to
Rack::TwilioWebhookAuthenticationmiddleware. The goal of having multiple tokens is to support Secondary Auth TokensA short description of what this PR does.
Checklist