fix: Allow configuring Faraday adapter with configure_connection block#683
Open
doryphores wants to merge 1 commit intotwilio:mainfrom
Open
fix: Allow configuring Faraday adapter with configure_connection block#683doryphores wants to merge 1 commit intotwilio:mainfrom
doryphores wants to merge 1 commit intotwilio:mainfrom
Conversation
b7b02bf to
496a1cf
Compare
496a1cf to
a821e31
Compare
Setting the adapter after calling the configure_connection blocks makes it impossible to configure the adapter with options.
a821e31 to
143d7bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
A small change to
Twilio::HTTP::Clientto allow us to configure the Faraday adapter withconfigure_connection.For example:
Without this change, the above configuration would be ignored because the adapter is reset after the configure connection blocks are applied.
And we cannot pass params to the adapter with the
adapteraccessor on the client instance:Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.