Skip to content

Add useful isValidHashtag() for java #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnlinp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add useful isValidHashtag() for java #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions java/src/main/java/com/twitter/twittertext/Validator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

package com.twitter.twittertext;

import java.util.List;

/**
* A class for validating Tweet texts.
*/
Expand Down Expand Up @@ -36,6 +38,24 @@ public boolean isValidTweet(String text) {
return TwitterTextParser.parseTweet(text).isValid;
}

/**
* Checks if a given text is a valid hashtag.
*
* @param text text to validate
* @return whether the text is a valid hashtag or not
*/
public boolean isValidHashtag(String text) {
if (text == null) {
return false;
}

Extractor extractor = new Extractor();
List<String> extracted = extractor.extractHashtags(text);

// Should extract the hashtag minus the # sign, hence the .substring(1)
return extracted.size() == 1 && extracted.get(0).equals(text.substring(1));
}

public static boolean hasInvalidCharacters(String text) {
return Regex.INVALID_CHARACTERS_PATTERN.matcher(text).matches();
}
Expand Down
13 changes: 13 additions & 0 deletions java/src/test/java/com/twitter/twittertext/ValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,17 @@ public void testMutiByteCharacters() {
assertTrue(validator.isValidTweet(builder.append(c).toString()));
assertFalse(validator.isValidTweet(builder.append(c).toString()));
}

public void testValidHashtags() {
assertTrue(validator.isValidHashtag("#test"));
assertTrue(validator.isValidHashtag("#\u53F0\u7063"));
}

public void testInvalidHashtags() {
assertFalse(validator.isValidHashtag("#test #test"));
assertFalse(validator.isValidHashtag("#test test"));
assertFalse(validator.isValidHashtag("#test,test"));
assertFalse(validator.isValidHashtag("test"));
assertFalse(validator.isValidHashtag(null));
}
}