support scala 3 build for util-tunable#305
Conversation
7a19477 to
cc03a3b
Compare
|
CI failed because sbt-scoverage was updated to 2.0.0 here. Once |
|
|
||
| object Key { | ||
| def apply[T](id: String)(implicit m: Manifest[T]): Key[T] = | ||
| def apply[T](id: String)(implicit m: ClassTag[T]): Key[T] = |
There was a problem hiding this comment.
Manifest no longer exists in Scala 3 and there is no equivalent replacement.
Since it is only used to retrieve the runtime class (which is erased anyway), ClassTag should work the same way here, as far as I understand it.
cc03a3b to
bf107cc
Compare
|
I've rebased this onto I've also had to change the Scala 3 version form Given that we currently don't have CI-checks for Scala 3 (see #310 for that) and it's still somewhat of a moving target, I'd rather just go for the up-to-date Scala 3 version, which we want anyway in the long run. edit: I should add that I ran |
This PR builds on #304 so that should be merged before this one imo.
With the new Jackson version supporting Scala 3 directly,
util-tunablewas just a config change.I'm not sure why
scala-collection-compat_3was excluded from the Scala 3 settings. It was probably an attempt to solve the "conflicting version suffix" error from sbt. I moved it to the Scala 2 settings but I can also remove it if you prefer.